WIP - Create Picocli example codestart for Quarkus JBang project type #13826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also exercise the bytecode in the test extension.
Bumps [caffeine](https://github.com/ben-manes/caffeine) from 2.8.6 to 2.8.7. - [Release notes](https://github.com/ben-manes/caffeine/releases) - [Commits](ben-manes/caffeine@v2.8.6...v2.8.7) Signed-off-by: dependabot[bot] <support@github.com>
In the repository pattern example the fields of Person are private. Therefore, in the following usage example setters have to be used instead of direct field access.
The previous error logging was obnoxious and cluttered the test logs for no good reason
1. It's not necessary, because we will contribute annotated classes through the scanner. 2. It's harmful, because getManagedClassNames() can also return *package* names, while annotatedClassNames is exclusively about classes. In the end, this leads to a ClassNotFoundError when Hibernate ORM interprets annotatedClassNames. Regarding the assertion "getManagedClassNames() can also return *package* names", see for proof: - how org.hibernate.boot.archive.scan.internal.ScanResultCollector.isListedOrDetectable is used for packages too, even though it relies (indirectly) on getManagedClassNames(). - the comment at org/hibernate/boot/model/process/internal/ScanningCoordinator.java:246: "IMPL NOTE : "explicitlyListedClassNames" can contain class or package names..." Signed-off-by: Yoann Rodière <yoann@hibernate.org>
…es() getManagedClassNames() can also return *package* names. See for proof: - how org.hibernate.boot.archive.scan.internal.ScanResultCollector.isListedOrDetectable is used for packages too, even though it relies (indirectly) on getManagedClassNames(). - the comment at org/hibernate/boot/model/process/internal/ScanningCoordinator.java:246: "IMPL NOTE : "explicitlyListedClassNames" can contain class or package names..." Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Bumps [flyway-core](https://github.com/flyway/flyway) from 7.3.0 to 7.3.1. - [Release notes](https://github.com/flyway/flyway/releases) - [Commits](flyway/flyway@flyway-7.3.0...flyway-7.3.1) Signed-off-by: dependabot[bot] <support@github.com>
Per discussion with Martin.
When importing a project.
ghost
added
area/arc
|
Sorry for the mess - I send another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your feedback!
EDIT: Okay, I screwed up with git rebase it seems like.
Closes #13208