Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Picoli example codestart for Quarkus JBang project type #13828

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Create Picoli example codestart for Quarkus JBang project type #13828

merged 3 commits into from
Jan 5, 2021

Conversation

nicobao
Copy link
Contributor

@nicobao nicobao commented Dec 10, 2020

Now it's better ^^'

Closes #13208

@ghost ghost added area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus labels Dec 10, 2020
@nicobao nicobao force-pushed the create-picocli-example-quarkus-jbang branch from 7de8263 to 62ca09c Compare December 11, 2020 21:04
@nicobao
Copy link
Contributor Author

nicobao commented Dec 11, 2020 •
edited
Loading

Hi,
I used "WIP" but actually, on my side it's all working - waiting for review.
In my local fork, build is passing except for JDK 11 Windows. For some reasons the build lasts for more than 3 hours and GitHub simply cancels it before it can terminate: https://github.com/nicobao/quarkus/actions/runs/414103123
/cc @ia3andy

ia3andy
ia3andy requested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!! Thanks a lot :) I added a few suggestions..

@nicobao nicobao force-pushed the create-picocli-example-quarkus-jbang branch from 62ca09c to 689775e Compare December 14, 2020 19:08
@nicobao
Copy link
Contributor Author

nicobao commented Dec 14, 2020

Hi @ia3andy
Just rebased and added your suggestion. Let me know if I can remove the "WIP"!

@ia3andy ia3andy changed the title WIP - Create Picoli example codestart for Quarkus JBang project type Create Picoli example codestart for Quarkus JBang project type Dec 14, 2020
ia3andy
ia3andy approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) thanks!! Waiting for CI..

@nicobao
Copy link
Contributor Author

nicobao commented Dec 17, 2020

Hi!
I think, for some reasons, the CI didn't started? All tests passed in my fork at least.
Do you need me to rebase btw?

@ia3andy
Copy link
Contributor

ia3andy commented Jan 4, 2021

I've tried to restart it, but it still skips the build @gsmet any thoughts?

in the meantime, @nicobao you could maybe force push a tiny change to re-trigger the CI?

@nicobao nicobao force-pushed the create-picocli-example-quarkus-jbang branch from 14b0474 to 1892d11 Compare January 4, 2021 21:03
@nicobao
Copy link
Contributor Author

nicobao commented Jan 4, 2021

Hi,
Happy New Year :).
Rebasing was enough to trigger a build!

@ia3andy ia3andy merged commit e3bbc08 into quarkusio:master Jan 5, 2021
@ghost ghost added this to the 1.11 - master milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus
Projects
None yet
Milestone
1.11.0.CR1
Development

Successfully merging this pull request may close these issues.

Create a Picocli example codestart for Quarkus JBang project type
2 participants
@nicobao @ia3andy