-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add properties for statement-batch-size and fetch.batch-size in hibernate-reactive #16646
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
/cc @DavideD, @Sanne, @gavinking |
Yeah sorry, I've been a bit busy with other issues, It looks fine at first glance but I will have better look at it soon |
@Sanne I just noticed this during development where I was confused about the sql statements sent by hibernate. If I find the time to do so I can try to add some tests. But I do not want to promise this because we are quite busy at the moment. |
Hi! This will need a rebase as things have been partially implemented here 49886c8#diff-0e6dba65e9fb565f0f6a85e937bcab1f9574091bfe5323a4965f085bbab07b5b already. |
@DavideD I'll assign this to you so it doesn't get lost. Please could you 1)have a look 2)resolve the conflicts 3)merge it ! |
I've rebased the PR and sent a new one here: #18241 But I've realized that, unrelated to Quarkus, Hibernate Reactive currently ignores the value set by the property. |
Fixes #16640
-HibernateReactiveProcessor adjusted so that it supports new property for quarkus.hibernate-orm.fetch.batch-size
-HibernateReactiveProcessor adjusted so that it supports property for quarkus.hibernate-orm.jdbc.statement-batch-size