Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties for statement-batch-size and fetch.batch-size in hibernate-reactive #16646

Closed
wants to merge 1 commit into from

Conversation

holomekc
Copy link
Contributor

@holomekc holomekc commented Apr 19, 2021

Fixes #16640

-HibernateReactiveProcessor adjusted so that it supports new property for quarkus.hibernate-orm.fetch.batch-size
-HibernateReactiveProcessor adjusted so that it supports property for quarkus.hibernate-orm.jdbc.statement-batch-size

-HibernateReactiveProcessor adjusted so that it supports new property for quarkus.hibernate-orm.fetch.batch-size
-HibernateReactiveProcessor adjusted so that it supports property for quarkus.hibernate-orm.jdbc.statement-batch-size
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 19, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE labels Apr 19, 2021
@holomekc holomekc changed the title Fix #16640 Add properties for statement-batch-size and fetch.batch-size in hibernate-reactive Apr 19, 2021
@holomekc
Copy link
Contributor Author

/cc @DavideD, @Sanne, @gavinking

@Sanne
Copy link
Member

Sanne commented Apr 21, 2021

@DavideD could you review this? Are these properties honoured in Hibernate Reactive?

Ideally someone should add a test as well. @holomekc would you be able?

@DavideD
Copy link
Contributor

DavideD commented Apr 21, 2021

Yeah sorry, I've been a bit busy with other issues, It looks fine at first glance but I will have better look at it soon

@holomekc
Copy link
Contributor Author

holomekc commented May 3, 2021

@Sanne
Sorry for my late answer. I did not really have time to create some tests. To be honest it feels like more configuration should be adjusted and I am not sure if I have all insights here what your plans are and if the two settings cover everything that is missing.

I just noticed this during development where I was confused about the sql statements sent by hibernate.

If I find the time to do so I can try to add some tests. But I do not want to promise this because we are quite busy at the moment.

@gsmet
Copy link
Member

gsmet commented May 11, 2021

Hi!

This will need a rebase as things have been partially implemented here 49886c8#diff-0e6dba65e9fb565f0f6a85e937bcab1f9574091bfe5323a4965f085bbab07b5b already.

@gsmet gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label May 11, 2021
@Sanne
Copy link
Member

Sanne commented Jun 21, 2021

@DavideD I'll assign this to you so it doesn't get lost. Please could you 1)have a look 2)resolve the conflicts 3)merge it !
Thanks

@DavideD
Copy link
Contributor

DavideD commented Jun 29, 2021

I've rebased the PR and sent a new one here: #18241

But I've realized that, unrelated to Quarkus, Hibernate Reactive currently ignores the value set by the property.

@Sanne Sanne closed this Jun 29, 2021
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE triage/invalid This doesn't seem right triage/needs-rebase This PR needs to be rebased first because it has merge conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hibernate-reactive statement-batch-size is not used
4 participants