Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix card layout in Dev UI #16985

Merged
merged 2 commits into from
May 7, 2021
Merged

Fix card layout in Dev UI #16985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3aed16
Fixs card layout
netodevel May 5, 2021
49458aa
Fixs padding guide button
netodevel May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions extensions/vertx-http/deployment/src/main/resources/dev-static/css/dev-console.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,7 @@ h1 {
overflow-y: auto;
overflow-x: hidden;
}

.guide-padding-right {
padding-right: 0.25rem;
}
16 changes: 11 additions & 5 deletions ...ions/vertx-http/deployment/src/main/resources/dev-templates/tags/actionableExtension.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
<div class="col mb-4">
<div class="card h-100 shadow">
<div class="card-header bg-primary text-light">
{it['name']}
{#if it['metadata'] && it['metadata']['guide']}
<a href="{it['metadata']['guide']}" class="text-light float-right" title="Guide"><i class="fa fa-book"></i></a>
{/if}
<div class="card-header bg-primary text-light guide-padding-right">
<div class="row">
<div class="col-md-10">
{it['name']}
</div>
<div class="col-md-1">
{#if it['metadata'] && it['metadata']['guide']}
<a href="{it['metadata']['guide']}" class="text-light float-right" title="Guide"><i class="fa fa-book"></i></a>
{/if}
</div>
</div>
</div>
<div class="card-body">
<p class="card-text">
Expand Down
16 changes: 11 additions & 5 deletions ...s/vertx-http/deployment/src/main/resources/dev-templates/tags/nonActionableExtension.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
{#if it['metadata'] && it['metadata']['unlisted'] != true}
<div class="col mb-4">
<div class="card h-100">
<div class="card-header">
{it['name']}
{#if it['metadata'] && it['metadata']['guide']}
<a href="{it['metadata']['guide']}" class="text-muted float-right" title="Guide"><i class="fa fa-book"></i></a>
{/if}
<div class="card-header guide-padding-right">
<div class="row">
<div class="col-md-10">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, but if I put 11, the button guide ends up going down.
I think it ends up leaving the limits of the bootstrap grid.

{it['name']}
</div>
<div class="col-md-1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, the icon is significantly more to the left. Could we adjust that with some alignment and padding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

padding done

after-style

{#if it['metadata'] && it['metadata']['guide']}
<a href="{it['metadata']['guide']}" class="text-muted float-right" title="Guide"><i class="fa fa-book"></i></a>
{/if}
</div>
</div>
</div>
<div class="card-body">
<p class="card-text">
Expand Down