Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC: support @Blocking on class #17575

Merged
merged 1 commit into from
Jun 2, 2021
Merged

gRPC: support @Blocking on class #17575

merged 1 commit into from
Jun 2, 2021

Conversation

michalszynkiewicz
Copy link
Member

fixes #17475

@michalszynkiewicz michalszynkiewicz requested a review from mkouba June 1, 2021 05:43
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Jun 1, 2021
@geoand
Copy link
Contributor

geoand commented Jun 1, 2021

Dump question: Is @NonBlocking supported? I mean can a user add @Blocking on a class and @NonBlocking on a method?

@michalszynkiewicz
Copy link
Member Author

I didn't know we had @NonBlocking, I'll add support for it

@geoand
Copy link
Contributor

geoand commented Jun 1, 2021

Great, thanks!

@mkouba
Copy link
Contributor

mkouba commented Jun 1, 2021

I didn't know we had @NonBlocking, I'll add support for it

I didn't know about this annotation either ;-)

Otherwise the PR looks good.

@mkouba
Copy link
Contributor

mkouba commented Jun 1, 2021

@michalszynkiewicz @gsmet I think that this one should be backported in 2.0.Final. WDYT?

@michalszynkiewicz michalszynkiewicz force-pushed the grpc-blocking-on-class branch from 651e2c3 to f46c444 Compare June 1, 2021 08:45
@michalszynkiewicz
Copy link
Member Author

updated to support @NonBlocking, and added a test for it.
👍🏻 on backport

@geoand
Copy link
Contributor

geoand commented Jun 1, 2021

It should certainly be backported to Final

mkouba
mkouba approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. I've sent a PR with minor change: michalszynkiewicz#10 ;-)

@michalszynkiewicz michalszynkiewicz force-pushed the grpc-blocking-on-class branch from 2ae7429 to ed3763a Compare June 1, 2021 20:05
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 1, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 2ae7429

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Gradle Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
⌛ Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
⌛ Native Tests - gRPC Build ⚠️ Check → Logs Raw logs

@michalszynkiewicz michalszynkiewicz added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 1, 2021
@michalszynkiewicz michalszynkiewicz merged commit 618cb6d into quarkusio:main Jun 2, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 2, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 2, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.CR3 Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/grpc gRPC
Projects
None yet
Milestone
2.0.0.CR3
Development

Successfully merging this pull request may close these issues.

Make @Blocking work on gRPC services
4 participants
@michalszynkiewicz @geoand @mkouba @gsmet