Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to GraphQL client user guide #17590

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Update to GraphQL client user guide #17590

merged 1 commit into from
Jun 2, 2021

Conversation

jmartisk
Copy link
Contributor

@jmartisk jmartisk commented Jun 1, 2021

Update to reflect the changes performed in #17556
If using the typesafe client, the rest client dependency must now be added explicitly.

@jmartisk jmartisk requested a review from phillip-kruger June 1, 2021 11:54
gsmet
gsmet requested changes Jun 1, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a paragraph about the client you need to use depending on the flavor of RESTEasy stack you are using.

That's not exactly easy to understand.

@jmartisk jmartisk force-pushed the update-graphql-client-docs branch from 008fac7 to 89e0e12 Compare June 2, 2021 09:05
@jmartisk
Copy link
Contributor Author

jmartisk commented Jun 2, 2021

I've added a NOTE explaining the dependency in more detail

@jmartisk jmartisk force-pushed the update-graphql-client-docs branch from 89e0e12 to 7c1bf18 Compare June 2, 2021 12:02
@jmartisk
Copy link
Contributor Author

jmartisk commented Jun 2, 2021

Applied @gsmet 's suggested wording :)

@gsmet gsmet merged commit f1a96ed into quarkusio:main Jun 2, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 2, 2021
@gsmet
Copy link
Member

gsmet commented Jun 2, 2021

Thanks!

@jmartisk jmartisk deleted the update-graphql-client-docs branch June 2, 2021 13:18
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.CR3 Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.0.0.CR3
Development

Successfully merging this pull request may close these issues.
3 participants
@jmartisk @gsmet @phillip-kruger