Apply tiny polish to DevMojo #17596
Merged
Apply tiny polish to DevMojo #17596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
geoand
force-pushed
the
devmojo-tiny-polish
branch
from
bfa2fe7 to
fd1adb6
Compare
|
This workflow status is outdated as a new workflow run has been triggered. |
cescoffier
approved these changes
Jun 2, 2021
| } catch (InterruptedException ignored) { | ||
| getLog().warn("Unable to properly wait for dev-mode end", ignored); | ||
| } catch (InterruptedException e) { | ||
| getLog().warn("Unable to properly wait for dev-mode end", e); |
There was a problem hiding this comment.
You should rest the interruption flag. (it was not done before)
There was a problem hiding this comment.
This is a shutdown hook, so does it really matter to do so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.