-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Jandex 2.3.0 #17606
Upgrade to Jandex 2.3.0 #17606
Conversation
The gradle plugin has been released in 0.11.0. |
@yrodiere should this be promoted from draft ? |
Not until the maven plugin get released, which should hopefully happen soon.
Le mar. 1 juin 2021 à 19:41, Sanne Grinovero ***@***.***> a
écrit :
… @yrodiere <https://github.com/yrodiere> should this be promoted from
draft ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17606 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADEZTVB6RRNY4N4X737SPLTQULV5ANCNFSM4544PNQQ>
.
|
…losingTarget()" This reverts the workaround from commit f6cffe0, but preserves the test. Assuming jandex indexes are always built with Jandex 2.3.0+, we no longer need this workaround.
I also just pushed an additional commit to disable the workaround on Hibernate Validator. I tested locally with the reproducer that Xavier Sanchez Taixe provided on Zulip (thanks for that!), upgrading to this patched version of Quarkus and |
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 10bd54a
Full information is available in the Build summary check run. Test Failures⚙️ MicroProfile TCKs Tests #📦 tcks/microprofile-graphql✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 5bbba93
Full information is available in the Build summary check run. Test Failures⚙️ MicroProfile TCKs Tests #📦 tcks/microprofile-graphql✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
It seems like GraphQL doesn't like it. @phillip-kruger can you please take a look? |
Note that the main change in this new version of Jandex is that type-use annotations are now returned by |
I'll have a look. Thanks :) |
Quite an adventure but here we are. Thanks everyone! |
Great job folks 👌 |
Nice!
…On Thu, 3 Jun 2021, 18:32 Georgios Andrianakis, ***@***.***> wrote:
Great job folks 👌
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#17606 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKMTIESE75MEV5K3PYZMDTQ64CXANCNFSM4544PNQQ>
.
|
👏🏻 |
Fixes #17491 by upgrading to Jandex 2.3.0, which includes smallrye/jandex#121
Draft because we're waiting for:
The Gradle plugin: bump/jandex kordamp/jandex-gradle-plugin#13 + wait for release=> DoneThe Maven plugin: Upgrade to Jandex 2.3.0 wildfly/jandex-maven-plugin#28 + wait for release=> Done