Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use main.java for JBang projects #17610

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Use main.java for JBang projects #17610

merged 1 commit into from
Jun 3, 2021

Conversation

ebullient
Copy link
Member

@ebullient ebullient commented Jun 1, 2021 •
edited by ia3andy
Loading

Use main.java in JBang projects

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 1, 2021
@ebullient ebullient mentioned this pull request Jun 1, 2021
Open
@ebullient ebullient marked this pull request as ready for review June 2, 2021 14:04
@ebullient ebullient requested a review from maxandersen June 2, 2021 14:05
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 2, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 2156132

Status Name Step Test failures Logs Raw logs
✖ Devtools Tests - JDK 11 Build Test failures Logs Raw logs
✖ Devtools Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Devtools Tests - JDK 11 #

📦 integration-tests/devtools

✖ io.quarkus.devtools.commands.CreateJBangProjectTest.createRESTEasyWithExtensions line 69 - More details - Source on GitHub

✖ io.quarkus.devtools.commands.CreateJBangProjectTest.createRESTEasy line 33 - More details - Source on GitHub

✖ io.quarkus.devtools.commands.CreateJBangProjectTest.createRESTEasyWithNoJBangWrapper line 49 - More details - Source on GitHub

⚙️ Devtools Tests - JDK 11 Windows #

📦 integration-tests/devtools

✖ io.quarkus.devtools.commands.CreateJBangProjectTest.createRESTEasyWithExtensions line 69 - More details - Source on GitHub

✖ io.quarkus.devtools.commands.CreateJBangProjectTest.createRESTEasy line 33 - More details - Source on GitHub

✖ io.quarkus.devtools.commands.CreateJBangProjectTest.createRESTEasyWithNoJBangWrapper line 49 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 #

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generateDefaultProject(TestInfo) line 35 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generatePicocliProject(TestInfo) line 49 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generateDefaultProject(TestInfo) line 35 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generatePicocliProject(TestInfo) line 49 - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generateDefaultProject(TestInfo) line 35 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generatePicocliProject(TestInfo) line 49 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 3, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 1cebd40

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
⌛ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generateDefaultProject(TestInfo) line 35 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generatePicocliProject(TestInfo) line 49 - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 57 - More details - Source on GitHub

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generateDefaultProject(TestInfo) line 35 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.jbang.QuarkusJBangCodestartGenerationTest.generatePicocliProject(TestInfo) line 49 - More details - Source on GitHub

@ebullient ebullient requested a review from ia3andy June 3, 2021 14:25
ia3andy
ia3andy approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@ia3andy ia3andy changed the title Use Main.java for JBang projects Use main.java for JBang projects Jun 3, 2021
@maxandersen
Copy link
Member

Lgtm

@ebullient ebullient merged commit 5f7622e into quarkusio:main Jun 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 3, 2021
@ebullient ebullient deleted the jbang-main branch June 3, 2021 20:06
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@maxandersen maxandersen maxandersen approved these changes

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@ebullient @maxandersen @ia3andy @gsmet