Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows input issue #17619

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Fix Windows input issue #17619

merged 1 commit into from
Jun 8, 2021

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Jun 2, 2021
@famod
Copy link
Member

famod commented Jun 2, 2021

What if -Djansi.passthrough=true is set? I'm using this on Windows with Git Bash because that shell doesn't need Jansi for coloring...

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 2, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e58f22f

Status Name Step Test failures Logs Raw logs
✖ Native Tests - Windows - hibernate-validator ⚠️ Check → Logs Raw logs

@stuartwdouglas
Copy link
Member Author

Did that fix this issue? I just saw it starting an input pump thread in the terminal constructor, not guarded by an if block.

@famod
Copy link
Member

famod commented Jun 2, 2021

I can check later today. My question was primarily about whether you were aware of that property (and checked whether it does anything here).

@famod
Copy link
Member

famod commented Jun 2, 2021

PS: My comment shall not prevent the merge of this PR.
I would have to take a closer look and chances are I won't be able to do so today.

@stuartwdouglas stuartwdouglas merged commit 96a1a52 into quarkusio:main Jun 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 8, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@stuartwdouglas @famod @geoand @gsmet