CLI: Change default short option to display version from "-V" to "-v" #17621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current short option to display the version is "-V" (uppercase): `quarkus -V`. This is set by Picocli, but can be changed using the `picocli.version.name.0` property. The problem with `-V` is that does not match with the other short options to display version in the extensions and other commands which is "-v". Also, in other command tools like `mvn`, the option is `-v`. I did check that the `-v` is not conflicting with other existing options.
quarkus-bot
bot
added
area/cli
|
cc @ebullient what do you think about this change? |
|
Looks better to me :). |
ebullient
approved these changes
Jun 2, 2021
|
works for me. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current short option to display the version is "-V" (uppercase):
quarkus -V. This is set by Picocli, but can be changed using thepicocli.version.name.0property.The problem with
-Vis that does not match with the other short options to display version in the extensions and other commands which is "-v".Also, in other command tools like
mvn, the option is-v.I did check and I think that the
-vis not conflicting with other existing options.