Allow specifying per-port nodePort #17659

geoand · 2021-06-03T08:52:04Z

Resolves: #17582

geoand · 2021-06-03T13:11:07Z

@iocanel can you take a look at this one? It would be nice to get into 2.0.0.CR3 :)

iocanel

LGTM.

It might make sense to match using the port name instead of/in addition to the target port.

geoand · 2021-06-04T11:05:21Z

LGTM.

It might make sense to match using the port name instead of/in addition to the target port.

Good idea! I updated the PR

quarkus-bot · 2021-06-04T11:19:05Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `164116f`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

geoand requested a review from iocanel June 3, 2021 08:52

quarkus-bot bot added the area/kubernetes label Jun 3, 2021

geoand added the triage/backport? label Jun 3, 2021

iocanel approved these changes Jun 4, 2021

View reviewed changes

geoand force-pushed the #17582 branch from d661bf8 to 164116f Compare June 4, 2021 11:05

geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 4, 2021

Allow specifying per-port nodePort

6db9384

Resolves: quarkusio#17582

geoand force-pushed the #17582 branch from 164116f to 6db9384 Compare June 4, 2021 11:29

geoand merged commit bffe513 into quarkusio:main Jun 4, 2021

quarkus-bot bot added this to the 2.1 - main milestone Jun 4, 2021

geoand deleted the #17582 branch June 4, 2021 13:11

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 4, 2021

gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 7, 2021

gsmet removed the triage/backport? label Jun 7, 2021