Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @Identifier instead of @Named in kafka client #17690

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Use @Identifier instead of @Named in kafka client #17690

merged 1 commit into from
Jun 4, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 4, 2021 •
edited
Loading

This is needed to remove a warning from SR RM.

Was originally reported here

@geoand geoand requested a review from cescoffier June 4, 2021 06:59
@geoand
Copy link
Contributor Author

geoand commented Jun 4, 2021

BTW, I was not able to run the tests locally, it seems like Red Panda could not start in testcontainers...

@geoand
Use @Identifier instead of @nAmed in kafka client
11bc00f 
This is needed to remove a warning from SR RM
@geoand geoand force-pushed the kafka-identifier branch from 4d54d16 to 11bc00f Compare June 4, 2021 07:39
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 4, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 4d54d16

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✖ JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs
⌛ Native Tests - Messaging1 Build ⚠️ Check → Logs Raw logs

@geoand geoand merged commit 4f8cf8b into quarkusio:main Jun 4, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 4, 2021
@geoand geoand deleted the kafka-identifier branch June 4, 2021 10:20
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 7, 2021
@ghost
Copy link

ghost commented Jun 12, 2021

@geoand Should this be fixed in CR3? Still seeing the warning.

@geoand
Copy link
Contributor Author

geoand commented Jun 12, 2021

The fix has not been included in 2.0.0.CR3, it will be available in the next 2.0.0.x release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@cescoffier cescoffier Awaiting requested review from cescoffier

Assignees
No one assigned
Labels
area/kafka area/kafka-streams
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @Ladicek @gsmet