Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Dev UI: slight improvements #17723

Merged

Conversation

michalszynkiewicz
Copy link
Member

How it looks after changes:
image

Please note the textareas resize to the content now for input and are set to min(size of output, 500px) for the output

@michalszynkiewicz michalszynkiewicz requested a review from mkouba June 7, 2021 06:54
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Jun 7, 2021
@michalszynkiewicz
Copy link
Member Author

If it's not a problem, I think it would be nice to have it in 2.0.0.
It does not affect any production code, just dev ui html/css changes.
OTOH, it's definitely low priority.

@michalszynkiewicz michalszynkiewicz added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 7, 2021
@michalszynkiewicz michalszynkiewicz merged commit d2c3116 into quarkusio:main Jun 7, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 7, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 7, 2021

🚫 This workflow run has been cancelled.

✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself.

@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants