Propagate Quarkus Redis Config to Vertx Redis Client #17738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate Quarkus Redis Config to Vertx Redis Client Propagate Quarkus Redis Config to Vertx Redis Client Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/SslConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/SslConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/SslConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/SslConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/SslConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/SslConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/SslConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Update extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/SslConfig.java Co-authored-by: Manyanda Chitimbo <manyanda.chitimbo@gmail.com> Peer Review changes
gsmet
approved these changes
Jun 7, 2021
|
@antoniodvr for your future contributions, always target the main branch. Then on a case by case basis, we backport PRs that are marked with the backport label. Otherwise we are at risk of missing some new features in the release coming after. Thanks! |
|
Sure @gsmet. I got confused by the fact that it was for Quarkus 2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #17714 (comment)
Thanks @gsmet for the good catch! Sorry for missing on it before the original PR was merged.
/cc @antoniodvr