Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce factory methods to create Redis clients dynamically #17739

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Introduce factory methods to create Redis clients dynamically #17739

merged 1 commit into from
Jun 9, 2021

Conversation

machi1990
Copy link
Member

Closes #13887

@machi1990 machi1990 requested review from gsmet and cescoffier June 7, 2021 19:21
@machi1990 machi1990 force-pushed the feat/add-creation-of-redis-client-programatically branch from 9d116d1 to cad9439 Compare June 7, 2021 19:31
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 7, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 9d116d1

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

cescoffier
cescoffier requested changes Jun 8, 2021
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor comments.

docs/src/main/asciidoc/redis.adoc Outdated Show resolved Hide resolved
...redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisClientsProducer.java Outdated Show resolved Hide resolved
.../redis-client/runtime/src/test/java/io/quarkus/redis/client/runtime/RedisClientUtilTest.java Outdated Show resolved Hide resolved
@machi1990 machi1990 force-pushed the feat/add-creation-of-redis-client-programatically branch 2 times, most recently from 9401185 to c5a2525 Compare June 8, 2021 07:49
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 9401185

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Set up job ⚠️ Check → Logs Raw logs
⌛ Attach pull request number Set up job ⚠️ Check → Logs Raw logs
⌛ CI Sanity Check Build ⚠️ Check → Logs Raw logs

@machi1990 machi1990 requested a review from cescoffier June 8, 2021 08:24
@machi1990 machi1990 force-pushed the feat/add-creation-of-redis-client-programatically branch from c5a2525 to 578b78f Compare June 8, 2021 09:40
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 578b78f

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 578b78f

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Set up JDK 11 ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 578b78f

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Set up JDK 11 ⚠️ Check → Logs Raw logs

@machi1990 machi1990 force-pushed the feat/add-creation-of-redis-client-programatically branch from 578b78f to 3f3178a Compare June 8, 2021 12:11
@machi1990 machi1990 requested a review from gsmet June 8, 2021 14:06
@geoand geoand merged commit f70b74e into quarkusio:main Jun 9, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 9, 2021
@machi1990 machi1990 deleted the feat/add-creation-of-redis-client-programatically branch June 9, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/documentation area/redis
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

Instantiate new Redis client
4 participants
@machi1990 @cescoffier @gsmet @geoand