Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove isAnnotation(ClassInfo) utility methods #17756

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

knutwannheden
Copy link
Contributor

There is now a dedicated ClassInfo#isAnnotation() method.

Also removes no longer used field BeanDeployment#CLASS_TYPES.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/spring Issues relating to the Spring integration area/testing labels Jun 8, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building eee2af0

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@knutwannheden knutwannheden force-pushed the classinfo-annotation branch from eee2af0 to 62607d1 Compare June 8, 2021 06:39
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 62607d1

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@knutwannheden knutwannheden force-pushed the classinfo-annotation branch from 62607d1 to cdd6e86 Compare June 8, 2021 07:40
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building cdd6e86

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

There is now a dedicated `ClassInfo#isAnnotation()` method.

Also removes no longer used field `BeanDeployment#CLASS_TYPES`.
@knutwannheden knutwannheden force-pushed the classinfo-annotation branch from cdd6e86 to 9698f23 Compare June 8, 2021 07:56
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 9698f23

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16
Native Tests - Misc4 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.QuarkusTestTypeTestCase.testQuarkusTestMode line 41 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 devtools/cli

io.quarkus.cli.CliProjectGradleTest.testExtensionList - More details - Source on GitHub

io.quarkus.cli.CliProjectGradleTest.testCreateAppDefaults - More details - Source on GitHub

io.quarkus.cli.CliProjectGradleTest.testCreateAppOverrides - More details - Source on GitHub

io.quarkus.cli.CliProjectMavenTest.testCreateAppDefaults - More details - Source on GitHub

io.quarkus.cli.CliProjectMavenTest.testCreateAppOverrides - More details - Source on GitHub

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 22, 2021
@mkouba mkouba merged commit 1a487e7 into quarkusio:main Jun 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 23, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/spring Issues relating to the Spring integration area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants