Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleScheduler - fix CronTrigger#evaluate() #17763

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 8, 2021

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ab144e2

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Set up JDK 11 ⚠️ Check → Logs Raw logs

Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI was not happy with the first run though, I relaunched it.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ab144e2

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Set up JDK 11 ⚠️ Check → Logs Raw logs

@mkouba
Copy link
Contributor Author

mkouba commented Jun 8, 2021

LGTM. CI was not happy with the first run though, I relaunched it.

GitHub has problems: https://www.githubstatus.com/ :-(

@mkouba
Copy link
Contributor Author

mkouba commented Jun 8, 2021

The change is described in #17724 (comment)

@machi1990 machi1990 merged commit 0e43a20 into quarkusio:main Jun 8, 2021
@gsmet
Copy link
Member

gsmet commented Jun 8, 2021

@mkouba VERY bad idea to rename the logger in the same commit. I have conflicts... When you want to backport a fix, please do NOT make cosmetic changes that don't bring anything to the plate.

@gsmet
Copy link
Member

gsmet commented Jun 8, 2021

I fixed the conflicts myself by saying that for next time.

@mkouba
Copy link
Contributor Author

mkouba commented Jun 9, 2021

@mkouba VERY bad idea to rename the logger in the same commit. I have conflicts... When you want to backport a fix, please do NOT make cosmetic changes that don't bring anything to the plate.

@gsmet I'm really sorry about that. I tried to make a diff locally and saw no conflicts. But this change was not only about renaming the logger, I also added/removed some log messages. Was it really the rename itself that caused the conflict?

@gsmet
Copy link
Member

gsmet commented Jun 9, 2021

Yes. Some methods are not in 1.13 and the fact that the logger name had changed made them present in the diff as they are logging something. There's a good chance they would have been ignored otherwise.

It wasn't too hard to fix it but for a more complex patch, that could have been a major pain thus my message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler is not triggered or triggered 2 times randomly with native image
3 participants