Minor QOL fix for Quarkus devs #17783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix means that if you recompile quarkus while you have a dev mode app running against it the app will be less likely to hang and need to be killed.
quarkus-bot
bot
added
the
area/devtools
gsmet
reviewed
Jun 9, 2021
| //been loaded | ||
| //this is just a convenience for quarkus devs that means exit | ||
| //should work properly if you recompile while quarkus is running | ||
| new ZipFileMayHaveChangedException(null); |
There was a problem hiding this comment.
You don't throw the exception, you just instantiate it?
|
Yes, this forces it to be loaded eagerly. If you have recompiled quarkus
then when it tries to load it it will fail.
The end result is a big stack trace and the app exiting, rather than a big
stack trace and the app hanging and needing to be killed.
…On Wed, 9 Jun 2021, 5:05 pm Guillaume Smet, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
independent-projects/bootstrap/core/src/main/java/io/quarkus/bootstrap/classloading/JarClassPathElement.java
<#17783 (comment)>:
> @@ -47,6 +47,12 @@
//version 8
}
JAVA_VERSION = version;
+ //force this class to be loaded
+ //if quarkus is recompiled it needs to have already
+ //been loaded
+ //this is just a convenience for quarkus devs that means exit
+ //should work properly if you recompile while quarkus is running
+ new ZipFileMayHaveChangedException(null);
You don't throw the exception, you just instantiate it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17783 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQG6YTRX3DUXD7SWOJ4N3TR4G6PANCNFSM46LIAKBQ>
.
|
Failing Jobs - Building 4af45dd
Full information is available in the Build summary check run. Test Failures⚙️ Maven Tests - JDK 11 #📦 integration-tests/maven✖ |
gsmet
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix means that if you recompile quarkus
while you have a dev mode app running against it
the app will be less likely to hang and need to
be killed.