Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC client proxies - prioritize delegating methods impl. on superclasses #17796

Merged
merged 1 commit into from
Jun 9, 2021
Merged

ArC client proxies - prioritize delegating methods impl. on superclasses #17796

merged 1 commit into from
Jun 9, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 9, 2021

@mkouba mkouba requested review from manovotn and Ladicek June 9, 2021 11:22
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jun 9, 2021
Ladicek
Ladicek approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and this is also more consistent with how inherited methods are looked up in Java.

@Ladicek
Copy link
Contributor

Ladicek commented Jun 9, 2021

Maybe add a test? The reproducer looked fairly small and self-contained.

manovotn
manovotn approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 9, 2021
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba mkouba merged commit d485042 into quarkusio:main Jun 9, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 9, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 9, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.

'Cannot delegate to an abstract method' for scoped bean with complex interfaces
4 participants
@mkouba @Ladicek @manovotn @gsmet