Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only close the span after all writing has finished #17826

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Only close the span after all writing has finished #17826

merged 1 commit into from
Jun 10, 2021

Conversation

bcluap
Copy link

@bcluap bcluap commented Jun 10, 2021

Close the span in a writer interceptor. Fixes one part of #16106

@gsmet gsmet requested a review from geoand June 10, 2021 09:20
geoand
geoand approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 5e9422d into quarkusio:main Jun 10, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 10, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/smallrye area/tracing
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@bcluap @geoand @gsmet