Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ring buffer default length to 3 #17852

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Change ring buffer default length to 3 #17852

merged 1 commit into from
Jun 11, 2021

Conversation

stuartwdouglas
Copy link
Member

3 is the Micrometer default, 1024 is way
to big and results in excessive memory usage.

@stuartwdouglas
Change ring buffer default length to 3
e29b69a 
3 is the Micrometer default, 1024 is way
to big and results in excessive memory usage.
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 11, 2021

/cc @ebullient, @kenfinnigan

gastaldi
gastaldi approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartwdouglas stuartwdouglas merged commit 6983ad5 into quarkusio:main Jun 11, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 11, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
@gsmet gsmet mentioned this pull request Dec 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebullient ebullient ebullient approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/metrics
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@stuartwdouglas @gastaldi @ebullient @gsmet