Fix potential NPE in RESTEasy Classic build time processing #17860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Jun 11, 2021
| @@ -51,7 +51,7 @@ void setUpDenyAllJaxRs(CombinedIndexBuildItem index, | |||
| JaxRsSecurityConfig config, | |||
| ResteasyDeploymentBuildItem resteasyDeployment, | |||
| BuildProducer<AdditionalSecuredClassesBuildItem> additionalSecuredClasses) { | |||
| if (config.denyJaxRs) { | |||
| if ((config.denyJaxRs) && (resteasyDeployment != null)) { | |||
There was a problem hiding this comment.
Isn’t the build item mandatory in this case? I’m surprised you don’t have an error instead of a null value.
There was a problem hiding this comment.
Yup, it's null. We also make this same check in another place as well.
I also tried it and it fixes the original issue
There was a problem hiding this comment.
@stuartwdouglas is it normal that an injected build item can be null? I thought we needed to use Optional in this case to avoid dependency injection issues?
There was a problem hiding this comment.
I don't remember what the behavior is, but I can certainly look into it if this becomes an issue
gsmet
approved these changes
Jun 11, 2021
gsmet
added
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17854