Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive SQL guide: document placeholders #18076

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Reactive SQL guide: document placeholders #18076

merged 1 commit into from
Jun 22, 2021

Conversation

tsegismont
Copy link
Contributor

Fixes #18056

Reactive SQL clients use different placeholders for prepared queries.
Now the database clients details section shows the differences.

@tsegismont tsegismont requested a review from cescoffier June 22, 2021 13:10
gsmet
gsmet requested changes Jun 22, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small formatting suggestion. I think it's especially important for ? as we want to make t clear it's a character, not something unknown :).

docs/src/main/asciidoc/reactive-sql-clients.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/reactive-sql-clients.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/reactive-sql-clients.adoc Outdated Show resolved Hide resolved
@tsegismont tsegismont requested a review from gsmet June 22, 2021 13:54
@tsegismont
Copy link
Contributor Author

Good point @gsmet . I commited the suggestions.

@tsegismont @gsmet
Reactive SQL guide: document placeholders
d7ef14b 
Fixes quarkusio#18056

Reactive SQL clients use different placeholders for prepared queries.
Now the database clients details section shows the differences.
@gsmet gsmet force-pushed the reactive_sql_placeholders branch from fbfd0c5 to d7ef14b Compare June 22, 2021 14:13
@gsmet
Copy link
Member

gsmet commented Jun 22, 2021

I squashed the commits, let's wait for CI.

@gsmet gsmet merged commit 039231e into quarkusio:main Jun 22, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 22, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 22, 2021
@tsegismont tsegismont deleted the reactive_sql_placeholders branch June 29, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.

Reactive SQL Client Documentation Missing Information
3 participants
@tsegismont @gsmet @cescoffier