Apply minor polish to ConfigUtils #18126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
commented
Jun 24, 2021
| } | ||
| } | ||
| return output; | ||
| BuildTimeSysPropMapProducer buildTimeSysPropMapProducer = new BuildTimeSysPropMapProducer(); |
There was a problem hiding this comment.
With this change we have fewer allocations as is evident by looking at how System.getProperties().entrySet() is implemented and also now use Map's forEach which is slightly optimized in the case of ConcurrentHashMap (which is the backing Map of Properties)
geoand
commented
Jun 24, 2021
| @@ -47,8 +47,6 @@ | |||
| * | |||
| */ | |||
| public final class ConfigUtils { | |||
| private static final Logger log = Logger.getLogger("io.quarkus.config"); | |||
There was a problem hiding this comment.
This was not used anywhere
Sanne
approved these changes
Jun 24, 2021
radcortez
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.