-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced quarkus-bootstrap-bom #18167
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 0076dc5
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 extensions/arc/deployment✖ |
0076dc5
to
7e232cf
Compare
I wonder if some deps should now be removed from the app BOM that are already in the bootstrap BOM, e.g. maven-resolver? |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 7e232cf
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 16 #📦 integration-tests/scala✖ |
Yes, I'll clean it up. Thanks. |
7e232cf
to
838dda9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
TBH, first I didn't really like the addition of yet another BOM, but after having digged myself for while, I now do also think that this is the only way to really enforce everything we need.
I'd just like to point out #9595, which introduced sisu to the app BOM. Maybe this should be revisited/moved as well.
838dda9
to
0d85188
Compare
Thanks for reviewing @famod I moved the sisu inject to the bootstrap bom. |
@aloubyansky this change causes a build warning (spotted locally);
|
Sorry about that #18196 |
Fixes #12628
This PR also makes sure the proper maven-settings artifact is used to parse the Maven settings file by the bootstrap module during the tests.