Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced quarkus-bootstrap-bom #18167

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

aloubyansky
Copy link
Member

Fixes #12628

This PR also makes sure the proper maven-settings artifact is used to parse the Maven settings file by the bootstrap module during the tests.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/testing labels Jun 25, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0076dc5

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16
Native Tests - Data3 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/arc/deployment

io.quarkus.arc.test.config.ConfigMappingTest. - More details - Source on GitHub

test-framework/common/log Outdated Show resolved Hide resolved
@famod
Copy link
Member

famod commented Jun 25, 2021

I wonder if some deps should now be removed from the app BOM that are already in the bootstrap BOM, e.g. maven-resolver?

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 26, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 7e232cf

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/scala

io.quarkus.scala.maven.it.ScalaRemoteDevModeIT.testThatTheApplicationIsReloadedOnScalaChange line 25 - More details - Source on GitHub

@aloubyansky
Copy link
Member Author

I wonder if some deps should now be removed from the app BOM that are already in the bootstrap BOM, e.g. maven-resolver?

Yes, I'll clean it up. Thanks.

Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
TBH, first I didn't really like the addition of yet another BOM, but after having digged myself for while, I now do also think that this is the only way to really enforce everything we need.

I'd just like to point out #9595, which introduced sisu to the app BOM. Maybe this should be revisited/moved as well.

@aloubyansky
Copy link
Member Author

Thanks for reviewing @famod I moved the sisu inject to the bootstrap bom.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 27, 2021

Failing Jobs - Building 0d85188

Status Name Step Test failures Logs Raw logs
Native Tests - Data3 Build ⚠️ Check → Logs Raw logs

@aloubyansky aloubyansky merged commit ff06500 into quarkusio:main Jun 28, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 28, 2021
@famod
Copy link
Member

famod commented Jun 28, 2021

@aloubyansky this change causes a build warning (spotted locally);

[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.quarkus:quarkus-bootstrap-bom:pom:999-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: io.quarkus:quarkus-bootstrap-core:jar -> duplicate declaration of version ${project.version} @ line 80, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: io.quarkus:quarkus-bootstrap-app-model:jar -> duplicate declaration of version ${project.version} @ line 92, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: io.quarkus:quarkus-bootstrap-maven-resolver:jar -> duplicate declaration of version ${project.version} @ line 97, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: io.quarkus:quarkus-bootstrap-gradle-resolver:jar -> duplicate declaration of version ${project.version} @ line 107, column 25
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]

@aloubyansky
Copy link
Member Author

Sorry about that #18196

@gsmet gsmet modified the milestones: 2.1 - main, 2.0.1.Final Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copy dependency management for bootstrap modules to quarkus-bom
3 participants