Fix distroless link #1824
Merged
Fix distroless link #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epository So it won't be lost during the release.
gsmet
reviewed
Apr 3, 2019
| @@ -242,7 +242,7 @@ And finally, run it with: | |||
| docker run -i --rm -p 8080:8080 quarkus-quickstart/quickstart | |||
| ---- | |||
|
|
|||
| NOTE: Interested by tiny Docker images, check the {quarkus-tree-url}/docker/distroless[distroless] version. | |||
| NOTE: Interested by tiny Docker images, check the {quarkus-images-url}/graalvm-1.0.0-rc14/distroless[distroless] version. | |||
There was a problem hiding this comment.
Shouldn't the GraalVM version be parameterized?
gsmet
requested changes
Apr 3, 2019
There was a problem hiding this comment.
We discussed it with @cescoffier, he will use a property for the version.
|
@gsmet Changes made. |
gsmet
approved these changes
Apr 3, 2019
iocanel
added a commit
to iocanel/quarkus
that referenced
this pull request
Jul 21, 2021
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Jul 21, 2021
… model (cherry picked from commit ad6a8ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply changes from quarkusio/quarkusio.github.io#145 to the quarkus repository
So it won't be lost during the release.