Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the recently merged NDJSON support in vertx-web #18280

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

ntrp
Copy link
Contributor

@ntrp ntrp commented Jun 30, 2021

I realized I did not add any documentation for the new merged feature so here it is. Please let me know if it should be improved or changed in any way.

The feature has been merged in PR #18182

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 30, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@ntrp ntrp changed the title Add documentation for PR #18182 Add documentation for the recently merged NDJSO support in vertx-web Jun 30, 2021
@ntrp ntrp changed the title Add documentation for the recently merged NDJSO support in vertx-web Add documentation for the recently merged NDJSON support in vertx-web Jun 30, 2021
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a minor correction

@@ -502,6 +502,55 @@ id: 3

----

=== Json Stream in NDJSON format

You can return a `Multi` to produce a newline delimited stream of JSON values.
Copy link
Contributor

@gastaldi gastaldi Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can return a `Multi` to produce a newline delimited stream of JSON values.
You can return a `Multi` to produce a stream of http://ndjson.org/[NDJSON] (Newline-delimited JSON) values.

@geoand geoand merged commit f974aa7 into quarkusio:main Jul 1, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants