Skip to content

Conversation

@gsmet
Copy link
Member

@gsmet gsmet commented Jul 8, 2021

Fix #18513

@zakkak I let you push this PR to your CI? Thanks!

@quarkus-bot quarkus-bot bot added the area/core label Jul 8, 2021
@zakkak
Copy link
Contributor

zakkak commented Jul 8, 2021

Closes #18513

@zakkak I let you push this PR to your CI? Thanks!

Started CI run: https://github.com/graalvm/mandrel/actions/runs/1011083032

Thanks

Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Guillaume!

Could we also add some comments tight above the changes that are for 20.3 compatibility so that we can easily grep them (and ultimately remove them) in the future?

Waiting for the CI to finish.... https://github.com/graalvm/mandrel/actions/runs/1011083032

@gsmet
Copy link
Member Author

gsmet commented Jul 8, 2021

@zakkak I think we'd better just revert the commit rather than track individual changes. So let's just make sure we can find the PRs we need to revert.

@zakkak
Copy link
Contributor

zakkak commented Jul 8, 2021

@gsmet OK

The tests in my CI run look good. Please merge once the Quarkus CI is happy as well :)

@gsmet
Copy link
Member Author

gsmet commented Jul 8, 2021

I will split some of the work into a separate PR as some fixes need to stay after reverting this.

@gsmet gsmet force-pushed the serialization-issue branch from d171da4 to 469daa1 Compare July 8, 2021 13:28
@gsmet
Copy link
Member Author

gsmet commented Jul 8, 2021

Note for future selves: when dropping Mandrel 20.3 support, please only revert the last commit!

@gsmet gsmet merged commit 196962e into quarkusio:main Jul 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serialization support breaks backwwards compatibility with GraalVM/Mandrel 20.3

2 participants