-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register profile specific configuration files for hot-reload #18735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But let's wait for @radcortez before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add the profiles for .env
, config
folder and quarkus.config.locations
? See https://github.com/quarkusio/quarkus/blob/d3d70ac5b97932bf2a2811ef796219d590ff2811/core/deployment/src/main/java/io/quarkus/deployment/steps/DevModeBuildStep.java
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 529b16f
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/jdbc/jdbc-mssql/deployment✖ |
Sure, just to make sure, that would means to register for example for the dev profile:
|
Yes.
No. Files can also be read from the
No. You can add additional locations (or files) with the configuration. For instance, |
@radcortez I pushed an update that adds all paths. |
@radcortez I let you drive this puppy home! |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building bd4e0c0
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/hibernate-reactive-panache✖
⚙️ MicroProfile TCKs Tests #📦 tcks/microprofile-fault-tolerance✖
|
Sure :) |
This branch registers
application-<profile>.properties
and yaml variant too for hot reload.close #18731