Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore case when comparing extension names #18815

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Ignore case when comparing extension names #18815

merged 1 commit into from
Jul 19, 2021

Conversation

gastaldi
Copy link
Contributor

Fixes #18808

@gastaldi gastaldi requested a review from ia3andy July 19, 2021 14:16
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jul 19, 2021
ia3andy
ia3andy approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gastaldi :)

Is it how you are testing the registry 😂

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 19, 2021
@gastaldi
Copy link
Contributor Author

@ia3andy yeah, I need a low-hanging fruit once in a while to maintain my sanity 😝

@gastaldi gastaldi force-pushed the compare_ext branch 2 times, most recently from 712fb4c to 14c1a44 Compare July 19, 2021 14:50
@gastaldi gastaldi merged commit be320a1 into quarkusio:main Jul 19, 2021
@gastaldi gastaldi deleted the compare_ext branch July 19, 2021 18:12
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 19, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 19, 2021
ia3andy added a commit to quarkusio/code.quarkus.io that referenced this pull request Jul 21, 2021
@ia3andy
Fix catalog test extensions order
7e7a4e3 
to be consistent with: quarkusio/quarkus#18815
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.0.Final Jul 21, 2021
ia3andy added a commit to quarkusio/code.quarkus.io that referenced this pull request Jul 21, 2021
@ia3andy
Fix catalog test extensions order
a3107dd 
to be consistent with: quarkusio/quarkus#18815
ia3andy added a commit to quarkusio/code.quarkus.io that referenced this pull request Jul 23, 2021
@ia3andy
Fix catalog test extensions order
e0a7195 
to be consistent with: quarkusio/quarkus#18815
ia3andy added a commit to quarkusio/code.quarkus.io that referenced this pull request Jul 26, 2021
@ia3andy
Fix catalog test extensions order
29853e3 
to be consistent with: quarkusio/quarkus#18815
ia3andy added a commit to quarkusio/code.quarkus.io that referenced this pull request Jul 27, 2021
@ia3andy
Fix catalog test extensions order
6ca0689 
to be consistent with: quarkusio/quarkus#18815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.1.0.Final
Development

Successfully merging this pull request may close these issues.

Extensions should be sorted case insensitive
3 participants
@gastaldi @ia3andy @gsmet