-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Vert.x TCCL management #18875
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building df6dc00
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/hibernate-orm/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/hibernate-orm/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
CI is very unhappy :). |
triggered a new CI run. |
There is definitely something wrong here. I will investigate today. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building df6dc00
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/hibernate-orm/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/hibernate-orm/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 815b69e
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/hibernate-orm/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 10c4e4b
Full information is available in the Build summary check run. Test Failures⚙️ Devtools Tests - JDK 11 #📦 integration-tests/devtools✖ ✖ ✖ ✖ ⚙️ Devtools Tests - JDK 11 Windows #📦 integration-tests/devtools✖ ✖ ✖ ✖ ⚙️ Gradle Tests - JDK 11 #📦 integration-tests/gradle/build/resources/test/add-remove-extension-single-module-kts✖ 📦 integration-tests/gradle/build/resources/test/add-remove-extension-single-module✖ 📦 integration-tests/gradle/build/resources/test/basic-java-library-module/application✖ 📦 integration-tests/gradle/build/resources/test/basic-java-platform-module/application✖ 📦 integration-tests/gradle/build/resources/test/basic-multi-module-project-test-setup/application✖ 📦 integration-tests/gradle/build/resources/test/bean-in-testsources-project✖ 📦 integration-tests/gradle/build/resources/test/custom-filesystem-provider/application✖ 📦 integration-tests/gradle/build/resources/test/inject-bean-from-test-config/application✖ 📦 integration-tests/gradle/build/resources/test/test-resources-in-build-steps/application✖ 📦 integration-tests/gradle/build/resources/test/test-resources-vs-main-resources✖ 📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle/build/resources/test/add-remove-extension-single-module-kts✖ 📦 integration-tests/gradle/build/resources/test/add-remove-extension-single-module✖ 📦 integration-tests/gradle/build/resources/test/basic-java-library-module/application✖ 📦 integration-tests/gradle/build/resources/test/basic-java-platform-module/application✖ 📦 integration-tests/gradle/build/resources/test/basic-multi-module-project-test-setup/application✖ 📦 integration-tests/gradle/build/resources/test/bean-in-testsources-project✖ 📦 integration-tests/gradle/build/resources/test/custom-filesystem-provider/application✖ 📦 integration-tests/gradle/build/resources/test/inject-bean-from-test-config/application✖ 📦 integration-tests/gradle/build/resources/test/test-resources-in-build-steps/application✖ 📦 integration-tests/gradle/build/resources/test/test-resources-vs-main-resources✖ 📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 #📦 devtools/cli✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 devtools/cli✖ ✖ |
There seems to be a pattern: all failed tests relate to Gradle. Even the CLI tests failing (at the end of the list) are the ones using gradle. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 3c469c9
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 extensions/hibernate-orm/deployment✖
|
This breaks dev mode, and in general is not needed as Quarkus can perform it's own TCCL management when required. It also provides a slight performance boost. Fixes quarkusio#18299
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building f2fd752
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/elytron-security-jdbc/deployment✖ 📦 extensions/hibernate-orm/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/elytron-security-jdbc/deployment✖ ✖ ✖ ✖ ✖ 📦 extensions/hibernate-orm/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/elytron-security-jdbc/deployment✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building e52e010
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/elytron-security-jdbc/deployment✖
⚙️ JVM Tests - JDK 11 Windows #📦 extensions/elytron-security-jdbc/deployment✖
✖
✖
✖
✖
⚙️ JVM Tests - JDK 16 #📦 extensions/elytron-security-jdbc/deployment✖
|
@Sanne assuming CI passes this should be ready to go. Removing the TCCL management exposed some different CL leaks (e.g. around continuous testing), which ended up causing other tests to fail, which is why I have had to add CL leak fixes into the PR. |
sounds great @stuartwdouglas :) |
FYI @vietj also has a PR improving the Vert.x SPI : I've tested it on top of your PR and it seems to work nicely; looking forward to the Vert.x 4.2 release so we can apply a little cleanups: |
Great stuff, thanks a lot for the efforts guys! |
This breaks dev mode, and in general is not needed as Quarkus can
perform it's own TCCL management when required. It also provides a
slight performance boost.
Fixes #18299