gradlew.bat/mvnw.bat should NOT be executable

[seregamorph]

If the gradle project is generated, the root directory listing has these gradle-wrapper related files:

ls -la demo/gradlew*
-rwxr-xr-x@ 1 morph  staff  8070 Oct  2 21:47 demo/gradlew
-rwxr-xr-x@ 1 morph  staff  2763 Oct  2 21:47 demo/gradlew.bat

The problem is that the second one, the bat file should not be executable, because it is auto-suggested in the shell to be executed, it raises inconvenience and requires manual fixing (via chmod). You can ensure and just list e.g. root directory of quarkus:

ls -la quarkus/mvnw*
-rwxr-xr-x  1 morph  staff  10069 Oct  3 19:50 quarkus/mvnw
-rw-r--r--  1 morph  staff   6607 Oct  3 19:50 quarkus/mvnw.cmd

The first file for *nix has the executable flag, the second file for Windows - does not.

This PR addresses the issue.

The same for maven wrapper bat executable.

[quarkus-bot]

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

• title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

[ia3andy]

Thanks @s-soroosh, can you confirm it won't change anything on Windows?

[gastaldi]

Can you squash both commits and let us know that this works on Windows?

[seregamorph]

BTW should I fix gradle-wrapper/codestart.yml and maven-wrapper/codestart.yml as well? cc @ia3andy

[ia3andy]

BTW should I fix gradle-wrapper/codestart.yml and maven-wrapper/codestart.yml as well? cc @ia3andy

There are two layers depending on if we zip the project or not:
While I am not sure how the executable are dealt for ZIP with on Window (this is why I asked if that wouldn't affect Windows).
I think this is going to be a problem if we remove setExecutable when not zipping on Windows (setExecutable is cross-platform AFAIK, and those files needs to be executable on Window too no?):
https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/core/strategy/ExecutableFileStrategyHandler.java#L31

[seregamorph]

I've played a bit with File.setExecutable(boolean, boolean) on WIndows machine. It seems that it does not have any effect, it's no-op. Even if executable=false is set to files, operating system does not prevent to execute them as usual.
Also I've found related discussion https://coderanch.com/t/567056/java/setExecutable-Windows-Machine that says the same

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building f2c18cb

Status	Name	Step	Failures	Logs	Raw logs
⌛	Maven Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs

[ia3andy]

@seregamorph awesome! thanks for the investigation :)

You are good to do both changes!

[ia3andy]

LGTM

[ia3andy]

is the CI failing due to that PR or something else?

[seregamorph]

@ia3andy , I cannot give guarantee, but I've checked last main branch commits, most of them have CI/CD objections (red cross):
https://github.com/quarkusio/quarkus/commits/main (JDK 11 Windows as well).

[ia3andy]

@seregamorph I've restarted the CI to be sure ;)

[geoand]

@ia3andy feel free to merge is this is good to go