Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare com.microsoft.azure:adal4j dependency as optional #22584

Closed
wants to merge 1 commit into from
Closed

Declare com.microsoft.azure:adal4j dependency as optional #22584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extensions/jdbc/jdbc-mssql/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@
<!--
adal4j isn't used directly but you need to have it around for compilation to succeed.
Since that's the only reason, doesn't seem necessary to require the specific version in the shared bom.
Newer versions of mssql-jdbc use msal4j rather than adal4j; thus declare dependency as optional.
-->
<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>adal4j</artifactId>
<version>1.6.6</version>
<optional>true</optional>
<exclusions>
<exclusion>
<groupId>org.apache.commons</groupId>
Expand Down
4 changes: 3 additions & 1 deletion ...kus/jdbc/mssql/runtime/graal/com/microsoft/sqlserver/jdbc/SQLServerJDBCSubstitutions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ private QuarkusSqlFedAuthToken getMSIAuthToken(String resource, String msiClient

}

class SQLServerJDBCSubstitutions {
@TargetClass(className = "com.microsoft.aad.adal4j.AuthenticationException")
@Substitute
final class AuthenticationExceptionSubstitutions {

}