Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ServiceProviderBuildItem List constructor, removing the array null check as the List is validated as well #2313

Merged
merged 1 commit into from
May 3, 2019
Merged

Adding ServiceProviderBuildItem List constructor, removing the array null check as the List is validated as well #2313

merged 1 commit into from
May 3, 2019

Conversation

sberyozkin
Copy link
Member

No description provided.

@sberyozkin
Copy link
Member Author

in io.quarkus.smallrye.opentracing.deployment.TracingTest is unstable on Linux, passed for me on Fedora

@sberyozkin
Copy link
Member Author

@gsmet can you please approve it ? Without this constructor one, with a List in the deployment module, has to convert it to the array, which is then converted back to List in the ServiceProviderBuiltItem

@starksm64 starksm64 merged commit f0139e3 into quarkusio:master May 3, 2019
@gsmet gsmet added this to the 0.15.0 milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starksm64 starksm64 starksm64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sberyozkin @starksm64 @gsmet