Add @Unremoveable annotation to Arc #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will follow up later with a second PR for the other part of the solution we discussed in #2576 |
geoand
force-pushed
the
unremovable
branch
3 times, most recently
from
166c9c4
to
7c933c8
Compare
|
LGTM, but @mkouba can merge it if he is happy with it. |
mkouba
requested changes
May 27, 2019
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/Unremovable.java
Outdated
Show resolved
Hide resolved
geoand
force-pushed
the
unremovable
branch
2 times, most recently
from
56d997f
to
ca53ea7
Compare
mkouba
reviewed
May 27, 2019
...deployment/src/main/java/io/quarkus/arc/deployment/AnnotatedUnremovableClassesProcessor.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
May 27, 2019
...deployment/src/main/java/io/quarkus/arc/deployment/AnnotatedUnremovableClassesProcessor.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
May 27, 2019
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/Unremovable.java
Outdated
Show resolved
Hide resolved
mkouba
approved these changes
May 27, 2019
mkouba
added
the
triage/waiting-for-ci
This is one part of the solutions discussed in quarkusio#2576
mkouba
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one part of the solutions discussed in #2576