UserTransaction should fire CDI context lifecycle events #28725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Oct 20, 2022
mkouba
commented
- such as @initialized(TransactionScoped.class)
- resolves QuarkusTransaction does not fire @Initialized(TransactionScoped.class) #28709
mkouba
changed the title
manovotn
reviewed
Oct 21, 2022
mkouba
commented
Oct 21, 2022
...yana-jta/runtime/src/main/java/io/quarkus/narayana/jta/runtime/NotifyingUserTransaction.java
Show resolved
Hide resolved
mkouba
commented
Oct 21, 2022
...yana-jta/runtime/src/main/java/io/quarkus/narayana/jta/runtime/NotifyingUserTransaction.java
Outdated
Show resolved
Hide resolved
mkouba
force-pushed
the
issue-28709
branch
2 times, most recently
from
9b66eef
to
f5afe2b
Compare
mkouba
requested review from
manovotn and
mmusgrov
and removed request for
mmusgrov
manovotn
approved these changes
Oct 21, 2022
...ana-jta/runtime/src/main/java/io/quarkus/narayana/jta/runtime/TransactionScopedNotifier.java
Outdated
Show resolved
Hide resolved
|
@mmusgrov feel free to push the "merge' button if you're ok with this fix. |
|
@mmusgrov can you take a look at this? |
|
Thanks @mmusgrov |
|
@mmusgrov comments resolved :-) |
mkouba
commented
Oct 25, 2022
...yana-jta/runtime/src/main/java/io/quarkus/narayana/jta/runtime/NotifyingUserTransaction.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
- such as @initialized(TransactionScoped.class) - resolves quarkusio#28709
manovotn
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
@mkouba Is this included in any 2.15.X? Because I can not see it in the release notes. |
Yes, it is. The release blog posts do not list all the bugfixes/features. You can find it in the full changelog of 2.15.0.CR1 though: https://github.com/quarkusio/quarkus/releases/tag/2.15.0.CR1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.