Add JsonbSerde to Kafka client module #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
requested changes
Jun 19, 2019
extensions/kafka-client/runtime/src/main/java/io/quarkus/kafka/client/serde/JsonbSerde.java
Outdated
Show resolved
Hide resolved
extensions/kafka-client/runtime/src/main/java/io/quarkus/kafka/client/serde/JsonbSerde.java
Outdated
Show resolved
Hide resolved
extensions/kafka-client/runtime/src/main/java/io/quarkus/kafka/client/serde/JsonbSerde.java
Outdated
Show resolved
Hide resolved
integration-tests/kafka/src/test/java/io/quarkus/it/kafka/streams/KafkaStreamsTest.java
Show resolved
Hide resolved
gunnarmorling
force-pushed
the
jsonb
branch
2 times, most recently
from
81bf2f6
to
fef7829
Compare
|
@cescoffier, reworked the commit to address your comment regarding the naming. It's now |
|
Waiting for CI. |
cescoffier
approved these changes
Jun 19, 2019
cescoffier
requested changes
Jun 19, 2019
...ons/kafka-client/runtime/src/main/java/io/quarkus/kafka/client/serialization/JsonbSerde.java
Outdated
Show resolved
Hide resolved
cescoffier
requested changes
Jun 19, 2019
...ons/kafka-client/runtime/src/main/java/io/quarkus/kafka/client/serialization/JsonbSerde.java
Outdated
Show resolved
Hide resolved
cescoffier
requested changes
Jun 19, 2019
...afka-client/runtime/src/main/java/io/quarkus/kafka/client/serialization/JsonbSerializer.java
Show resolved
Hide resolved
|
@cescoffier, Next try, sent an update. How hard can it be :) |
|
Thanks @gunnarmorling, look great now. Even thinking making is a noteworthy-feature. |
cescoffier
approved these changes
Jun 19, 2019
gsmet
added
the
triage/waiting-for-ci
gsmet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gsmet, @cescoffier, here's a follow-up to the Kafka Streams work which should ideally go into the next release: it adds the JSON-B based SerDe ready for re-use to the runtime module, as suggested by Clement. It will simplify the quickstart code.
Note I've removed the JSON-P based SerDe which existed in the tests before for the sake of the new one. We also could consider to add this one ready-made, too, but it doesn't strike as super-important to me.
See #2663