Allow the use of specific user for DML updates in Flyway #29704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
geoand
changed the title
geoand
changed the title
gastaldi
requested changes
Dec 7, 2022
...ns/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayDataSourceRuntimeConfig.java
Show resolved
Hide resolved
Comment on lines
+47
to
+64
| void testDifferentUserConfig() throws SQLException { | ||
| FlywayDataSourceRuntimeConfig runtimeConfig = FlywayDataSourceRuntimeConfig.defaultConfig(); | ||
| FlywayDataSourceBuildTimeConfig buildConfig = FlywayDataSourceBuildTimeConfig.defaultConfig(); | ||
| runtimeConfig.username = runtimeConfig.username.of("sa"); | ||
| runtimeConfig.password = runtimeConfig.password.of("sa"); | ||
| runtimeConfig.jdbcUrl = runtimeConfig.jdbcUrl.of("jdbc:h2:~/test"); | ||
| creator = new FlywayCreator(runtimeConfig, buildConfig); | ||
| Flyway flyway = creator.createFlyway(dataSource); | ||
| boolean error = false; | ||
| try { | ||
| flyway.validate(); | ||
| } catch (Exception ex) { | ||
| ex.printStackTrace(); | ||
| error = true; | ||
| } | ||
|
|
||
| assertEquals(false, error, "Database connection with different user failed! "); | ||
| } |
There was a problem hiding this comment.
I still don't think this test is right.
Ideally the test(s) should check if the Flyway configuration is using the expected JDBC URL, user and password when provided
|
|
||
| import javax.sql.DataSource; | ||
|
|
||
| public class DataSourceDecorator implements DataSource { |
There was a problem hiding this comment.
Suggested change
| public class DataSourceDecorator implements DataSource { | |
| /** | |
| * Calls getConnection(user,password) for a given when getConnection() is called | |
| */ | |
| class CredentialsDataSource implements DataSource { |
Comment on lines
+13
to
+15
| private DataSource dataSource; | ||
| private String username; | ||
| private String password; |
gastaldi
reviewed
Dec 7, 2022
Comment on lines
+41
to
+45
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-test-h2</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
This needs to be moved to the <!-- test dependencies --> section below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24639