Flyway Datasource Credentials for issue #24639 #29744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
sberyozkin
reviewed
Dec 8, 2022
| */ | ||
|
|
||
| @ConfigItem | ||
| public Optional<String> password = Optional.empty(); |
There was a problem hiding this comment.
The standard user credentials can also be supplied with CredentialsProvider so I believe the Flyway specific user credentials should also be managed the same way as it is done in Agroal
sberyozkin
reviewed
Dec 8, 2022
...ns/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayDataSourceRuntimeConfig.java
Show resolved
Hide resolved
sberyozkin
reviewed
Dec 8, 2022
| public Optional<String> username = Optional.empty(); | ||
|
|
||
| /** | ||
| * Set a password that will Flyway will use to connect to the datasource. |
There was a problem hiding this comment.
Suggested change
| * Set a password that will Flyway will use to connect to the datasource. | |
| * Set a password that Flyway will use to connect to the datasource. |
sberyozkin
reviewed
Dec 8, 2022
| public Optional<String> password = Optional.empty(); | ||
|
|
||
| /** | ||
| * Set a new jdbcurl that will Flyway will use to connect to the datasource. |
There was a problem hiding this comment.
Suggested change
| * Set a new jdbcurl that will Flyway will use to connect to the datasource. | |
| * Set a new jdbcurl that Flyway will use to connect to the datasource. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure dedicated db user for database migrations: DML-only user for datasource, but DDL user for migration
Fixes: #24639