Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump smallrye-open-api from 2.3.1 to 3.1.1 #29815

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

MikeEdgar
Copy link
Contributor

Also includes

  • version management of microprofile-openapi-api at version 2.0.1
  • Jakarta rewrite version management of microprofile-openapi-api at version 3.0

SmallRye OpenAPI 3.1.x supports MicroProfile OpenAPI 2.0, 3.0, and 3.1 (TCK results attached to the release).

This PR updates to the latest SmallRye version, keeps the MicroProfile OpenAPI version the same as v2.3.1, and uses MicroProfile OpenAPI version 3.0 for the Jakarta migration. Eventually, using MicroProfile OpenAPI 3.1 will allow for MicroProfile 6.0 compliance.

Also includes
- version management of microprofile-openapi-api at version 2.0.1
- Jakarta rewrite version management of microprofile-openapi-api at
version 3.0
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/jakarta labels Dec 12, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 12, 2022

<smallrye-common.version>1.13.2</smallrye-common.version>
<smallrye-config.version>2.13.0</smallrye-config.version>
<smallrye-health.version>3.3.1</smallrye-health.version>
<smallrye-metrics.version>3.0.5</smallrye-metrics.version>
<smallrye-open-api.version>2.3.1</smallrye-open-api.version>
<smallrye-open-api.version>3.1.1</smallrye-open-api.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this version will work in main with the javax packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. The scanning is all Jandex-based and both top-level packages are scanned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If main includes the Jakarta migration (or even MP 6), I'll need to update the version for microprofile-openapi.version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, no, what you did is perfect.

@MikeEdgar MikeEdgar marked this pull request as ready for review December 13, 2022 12:18
@MikeEdgar
Copy link
Contributor Author

Marking ready for review, let's see how the CI behaves :-)

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 13, 2022

Failing Jobs - Building c59cdce

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@gsmet gsmet merged commit ab59738 into quarkusio:main Dec 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 13, 2022
@MikeEdgar MikeEdgar deleted the sroai-3.1.1 branch December 13, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/jakarta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants