Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Federation annotations are in the index, add a test #30143

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Make sure Federation annotations are in the index, add a test #30143

merged 1 commit into from
Jan 3, 2023

Conversation

jmartisk
Copy link
Contributor

@jmartisk jmartisk commented Jan 3, 2023

Fixes #30129

gsmet
gsmet approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I approve it so that I can get it in 2.15.2.Final that I will release tomorrow.

@jmartisk jmartisk merged commit a2948ae into quarkusio:main Jan 3, 2023
@jmartisk jmartisk deleted the main-issue-30129 branch January 3, 2023 13:15
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Jan 3, 2023
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.2.Final Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@phillip-kruger phillip-kruger Awaiting requested review from phillip-kruger

Assignees
No one assigned
Labels
area/graphql area/smallrye kind/bugfix
Projects
None yet
Milestone
2.15.2.Final
Development

Successfully merging this pull request may close these issues.

GraphQL federation directives do not appear in the schema
2 participants
@jmartisk @gsmet