Drop and ban commons-io dependency from quarkus-core-deployment #30542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/amazon-lambda
area/core
area/dependencies
jorsol
commented
Jan 23, 2023
| @@ -30,6 +30,10 @@ | |||
| <groupId>io.smallrye</groupId> | |||
| <artifactId>jandex</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>commons-io</groupId> | |||
| <artifactId>commons-io</artifactId> | |||
There was a problem hiding this comment.
Required in this module since it's using org.apache.commons.io.input.TeeInputStream in DefaultDockerContainerLauncher.java
|
Hi @gsmet, this is a follow up of #30108 (comment) to drop commons-io from quarkus-core-deployment: |
quarkus-bot
bot
added
area/hibernate-orm
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I will have a look at this soon. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This also update forbiddenapis to 3.4 and substitute calls to org.apache.commons.io.IOUtils#copy(java.io.InputStream,java.io.OutputStream) and org.apache.commons.compress.utils.IOUtils#copy(java.io.InputStream,java.io.OutputStream) using java.io.InputStream#transferTo(java.io.OutputStream) Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
gsmet
approved these changes
Jan 30, 2023
|
Thanks a lot! |
famod
reviewed
Jan 30, 2023
| @defaultMessage Never use Type#toString() as it's almost always the wrong thing to do. Usually org.jboss.jandex.DotName#toString() is what is needed | ||
| org.jboss.jandex.Type#toString() | ||
|
|
||
| org.apache.commons.io.** @ Don't use commons-io dependency |
There was a problem hiding this comment.
I'm probably missing something, but why aren't we using maven-enforcer's bannedDependencies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency
commons-iofromquarkus-core-deploymentand add a ban in the module.This also update forbiddenapis to 3.4 and substitute calls to
org.apache.commons.io.IOUtils#copy(java.io.InputStream,java.io.OutputStream)andorg.apache.commons.compress.utils.IOUtils#copy(java.io.InputStream,java.io.OutputStream)usingjava.io.InputStream#transferTo(java.io.OutputStream)