Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various small fixes #31358

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Various small fixes #31358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7775272
Handle a corner case in Timing printing
gsmet Feb 22, 2023
a2beed2
Fix a typo in the description of kubernetes-client/deployment-internal
gsmet Feb 22, 2023
1cb85f4
Remove an unused constant from KubernetesProcessor
gsmet Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/kubernetes-client/deployment-internal/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<artifactId>quarkus-kubernetes-client-internal-deployment</artifactId>
<name>Quarkus - Kubernetes Client - Internal - Deployment</name>
<description>This module only exists as a separate module to so the kubernetes extension can share code with the kubernetes-client extension</description>
<description>This module only exists as a separate module so the kubernetes extension can share code with the kubernetes-client extension</description>

<dependencies>
<dependency>
Expand Down
1 change: 0 additions & 1 deletion ...anilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ class KubernetesProcessor {
private static final Logger log = Logger.getLogger(KubernetesProcessor.class);

private static final String COMMON = "common";
private static final String OUTPUT_ARTIFACT_FORMAT = "%s%s.jar";

@BuildStep
FeatureBuildItem produceFeature() {
Expand Down
10 changes: 7 additions & 3 deletions independent-projects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/runner/Timing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,19 @@ public static void printStartupTime(String name, String version, String quarkusV
//Use a BigDecimal so we can render in seconds with 3 digits precision, as requested:
final BigDecimal secondsRepresentation = convertToBigDecimalSeconds(bootTimeNanoSeconds);
String safeAppName = (name == null || name.trim().isEmpty()) ? UNSET_VALUE : name;
String safeAppVersion = (version == null || version.trim().isEmpty()) ? UNSET_VALUE : version;
String safeAppVersion = (version == null || version.trim().isEmpty() || "null".equals(version)) ? UNSET_VALUE : version;
final String nativeOrJvm = ImageInfo.inImageRuntimeCode() ? "native" : "on JVM";
if (UNSET_VALUE.equals(safeAppName) || UNSET_VALUE.equals(safeAppVersion)) {

if (UNSET_VALUE.equals(safeAppName)) {
logger.infof("Quarkus %s %s started in %ss. %s", quarkusVersion, nativeOrJvm, secondsRepresentation,
t.httpServerInfo);
} else {
logger.infof("%s %s %s (powered by Quarkus %s) started in %ss. %s", name, version, nativeOrJvm, quarkusVersion,
String appNameAndVersion = UNSET_VALUE.equals(safeAppVersion) ? name : name + " " + version;

logger.infof("%s %s (powered by Quarkus %s) started in %ss. %s", appNameAndVersion, nativeOrJvm, quarkusVersion,
secondsRepresentation, t.httpServerInfo);
}

logger.infof("Profile%s %s activated. %s", profiles.size() > 1 ? "s" : "", String.join(",", profiles),
liveCoding ? "Live Coding activated." : "");
logger.infof("Installed features: [%s]", features);
Expand Down