Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Ensure that ConfigBuilder classes work in native mode to 2.13 #32278

Merged
merged 1 commit into from
May 15, 2023

Conversation

radcortez
Copy link
Member

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 30, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@radcortez radcortez changed the title Backport #30220 to 2.13 Backport Ensure that ConfigBuilder classes work in native mode to 2.13 Mar 30, 2023
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@gsmet gsmet added this to the 2.13.8.Final milestone Mar 31, 2023
@gsmet gsmet self-assigned this Mar 31, 2023
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to fix 2.13 CI. I will have a look at this this week-end.

@radcortez
Copy link
Member Author

The failures in ProviderConfigInjectionWarningsTest are picking up an additional warning:

WARN  [org.jbo.res.cli.jax.i18n] (Finalizer) RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ApacheHttpClient43Engine instance for you. Please close clients yourself.

I guess we also need #31496.

@gsmet
Copy link
Member

gsmet commented Apr 2, 2023

@radcortez yeah I have to backport a few CI fixes to older branches.

This fix is needed because without it main fails, for example
in io.quarkus.it.resteasy.reactive.elytron.FruitResourceIT with
a CNFE when trying to load
io.quarkus.security.runtime.QuarkusSecurityRolesAllowedConfigBuilder
@quarkus-bot
Copy link

quarkus-bot bot commented May 9, 2023

Failing Jobs - Building 28ea588

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 18 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment 
! Skipped: extensions/avro/deployment extensions/csrf-reactive/deployment extensions/grpc/deployment and 115 more

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

io.quarkus.resteasy.reactive.server.test.RequestLeakDetectionTest.testWithConcurrentBlockingCalls - More details - Source on GitHub

java.util.concurrent.RejectedExecutionException
	at org.jboss.threads.RejectingExecutor.execute(RejectingExecutor.java:38)
	at org.jboss.threads.EnhancedQueueExecutor.rejectShutdown(EnhancedQueueExecutor.java:2076)

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/logging-gelf 

📦 integration-tests/logging-gelf

io.quarkus.logging.gelf.it.GelfLogHandlerTest.test line 32 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.logging.gelf.it.GelfLogHandlerTest expected: not <null> within 20 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green enough.

@gsmet gsmet merged commit 19597e9 into quarkusio:2.13 May 15, 2023
jerboaa added a commit to jerboaa/graal that referenced this pull request Jun 1, 2023
This fixes the CI failure related to the test extension
tests when using the 22.3 builder image.

See: quarkusio/quarkus#32278
jerboaa added a commit to graalvm/mandrel that referenced this pull request Jun 1, 2023
This fixes the CI failure related to the test extension
tests when using the 22.3 builder image.

See: quarkusio/quarkus#32278
@radcortez radcortez deleted the backports-2.13 branch July 5, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants