Ensure the Quarkus HTTP Client Factory is always used by Kubernetes Client #32977
Conversation
Sgitario
changed the title
|
@geoand if the Quarkus HTTP Client Factory is the one that our Kubernetes Client instance must use, why not force the httpClientFactory to always use it? Note that this will disable the ServiceLoader logic to find any other. |
|
That's up for debate actually - cc @metacosm. |
|
So let's wait and see what other think |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
Which issue is this suppose to address? Regarding whether or not the factory should be used all the time, I don't know for sure. We still want people to be able to use a different http client implementation if they need to. That said, they could just provide their own Kubernetes client provider, configuring the client as they want so maybe that's fine. |
#32937 is the issue we're trying to fix. |
This is what we need to figure out before anything else |
|
Actually, it probably does work as expected, but my guess is that the client that is created at build time is causing the issue. In that case, we migjht want to limit disabling Service Discovery only to that client |
Do you mean the one we created to deploy into OpenShift [1]? If so, I don't think you're right. We have disabled the Service Discovery for this client already. |
|
Yeah I never tried it, just wondering. |
I would like to help with this. Though, if the Quarkus HTTP Client Factory is meant to always be used here, the simplest solution is this one. Yet if you want me to investigate why RemovedResourceBuildItem does not work in DEV mode, I would need some pointers to know where to start looking into as I have no idea. |
I won't have time for this for the next 10 days or so (same goes for others who are familiar with this part of the code). For a starting point for dev-mode, look into |
|
I've just confirmed that DEV mode is not consuming the Honestly, I don't see how DEV mode is meant to consume these build items, so I won't be helpful here. Anyway, I'm closing this pull request as the suggested solution seems not to be valid. |
|
The warning will be improved in the next version of the fabric8 client and yes, it shows up because the Kubernetes client extension adds an additional factory, we should indeed try to mute the warning in the case where there's only the original vert.x factory and the one that the extension creates. I'll take a look. |
Fix #32937