Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute - support optional end tags for sections #33296

Merged
merged 1 commit into from
May 11, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 11, 2023

{#let foo=true}
// foo can be used here

// synthetic {/let} added automatically
// foo cannot be used here
{#if baz}
{#let foo=true}
// foo can be used here

// synthetic {/let} added automatically
{/if}
// foo cannot be used here

So far only the {#let} and {#include} section support optional end tags. I think that it would be quite confusing for {#if}, {#for} and others...

CC @ia3andy @angelozerr

@github-actions
Copy link

github-actions bot commented May 11, 2023

🙈 The PR is closed and the preview is expired.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if (state == State.TAG_INSIDE_STRING_LITERAL) {
reason = "unterminated string literal";
code = ParserError.UNTERMINATED_STRING_LITERAL;
} else if (state == State.TAG_INSIDE) {
reason = "unterminated section";
code = ParserError.UNTERMINATED_SECTION;
// First handle the optional end tags and if an unterminated section is found the then throw an exception
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose found the then throw is a typo? But it's not worth re-running CI for that...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right 🤦

@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2023

Failing Jobs - Building 0fbcda5

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.KotlinProjectWithCompilerArgsDevModeTest.main line 17 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute - support optional end tags for sections
3 participants