-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qute - support optional end tags for sections #33296
Conversation
🙈 The PR is closed and the preview is expired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
if (state == State.TAG_INSIDE_STRING_LITERAL) { | ||
reason = "unterminated string literal"; | ||
code = ParserError.UNTERMINATED_STRING_LITERAL; | ||
} else if (state == State.TAG_INSIDE) { | ||
reason = "unterminated section"; | ||
code = ParserError.UNTERMINATED_SECTION; | ||
// First handle the optional end tags and if an unterminated section is found the then throw an exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose found the then throw is a typo? But it's not worth re-running CI for that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right 🤦
Failing Jobs - Building 0fbcda5
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
So far only the
{#let}
and{#include}
section support optional end tags. I think that it would be quite confusing for{#if}
,{#for}
and others...CC @ia3andy @angelozerr