Upgrade to smallrye-config 1.3.9 #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
force-pushed
the
smallrye-config
branch
from
0237bfa to
9d4356a
Compare
|
@dmlloyd coud you clarify why it's a Draft PR? You have identified some issues or you're waiting for something else? |
|
Right now it's a draft because I wasn't sure it was going to work, and it didn't ;). But I think we can make it a "real" PR as soon as I've fixed the problems, which I think I'm quite close to doing. |
dmlloyd
force-pushed
the
smallrye-config
branch
from
9d4356a to
c2e7ba0
Compare
|
The TCK problem is at the heart of eclipse/microprofile-config#407. If we decide to go ahead with this, we may have to disable some TCK tests. Update: I've included the same TCK disables that are included in SmallRye Config 1.3.9. |
dmlloyd
force-pushed
the
smallrye-config
branch
3 times, most recently
from
fe30948 to
9eb8109
Compare
|
Windows failure seems unrelated. |
gsmet
requested changes
Aug 23, 2019
core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigInstantiator.java
Outdated
Show resolved
Hide resolved
dmlloyd
force-pushed
the
smallrye-config
branch
from
9eb8109 to
e2ee052
Compare
|
Just waiting for your OK @gsmet |
gsmet
approved these changes
Aug 26, 2019
This was referenced Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.