-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URL for Dev UI es-shims #36546
Fix URL for Dev UI es-shims #36546
Conversation
b0825da
to
cea0f00
Compare
...nsions/vertx-http/dev-ui-resources/src/main/resources/dev-ui-templates/build-time/index.html
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @gsmet - avoiding a hardcoded version in our codebase would be much better. Do you think it's possible to extract the resolved version and use that one instead?
Yes that should be possible, I'll have a look |
cea0f00
to
798d388
Compare
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
798d388
to
14bf544
Compare
Failing Jobs - Building 14bf544
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 20 #- Failing: extensions/oidc-client-graphql/deployment
📦 extensions/oidc-client-graphql/deployment✖
⚙️ Maven Tests - JDK 11 Windows #📦 integration-tests/maven✖
✖
✖
✖
✖
✖
✖
✖
|
Small fix for Dev UI