Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent concurrently running Jacoco ReportCreators to avoid report corruption #37570

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Prevent concurrently running Jacoco ReportCreators to avoid report corruption #37570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test-framework/jacoco/runtime/src/main/java/io/quarkus/jacoco/runtime/ReportCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@ public ReportCreator(ReportInfo reportInfo, JacocoConfig config) {

@Override
public void run() {
// Ugly workaround:
// Multiple ReportCreator shutdown hooks might run concurrently, possibly corrupting the report file(s) - e.g. when using @TestProfile.
// By locking on a class from the parent CL, all hooks are "serialized", one after another.
// In the long run there should only be as many hooks as there are different Jacoco configs...usually there will be only one config anyway!
synchronized (ExecFileLoader.class) {
doRun();
}
}

private void doRun() {
File targetdir = new File(reportInfo.reportDir);
targetdir.mkdirs();
try {
Expand Down